Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with React 19 (and React 18) #1723

Open
catchergeese opened this issue Aug 19, 2024 · 9 comments
Open

Compatibility with React 19 (and React 18) #1723

catchergeese opened this issue Aug 19, 2024 · 9 comments
Labels
stale Used to mark when there was no activity for a set period of time

Comments

@catchergeese
Copy link

Currently, rich-text-react-renderer does not always work with React 19 (and shows a deprecation message on React 18).

In particular, the case that breaks for me is when I click "Hyperlink" in rich text editor toolbar:
image

The code responsible for this action's failure is in ModalDialogLauncher.tsx.

It uses pre-React 18 method of attaching a root React node on HTML element in DOM. Migration to an updated React API is trivial and well-documented. I believe it should also be possible to provide both APIs at the same time with a runtime check.

Would it be possible to migrate this part to enable users on React 18 and React 19?
@github-actions GitHub Actions
Copy link

Marking issue as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Sep 19, 2024
@catchergeese
Copy link
Author

catchergeese commented Sep 19, 2024 •
edited
Loading

This issue still persists.

@github-actions github-actions bot removed the stale Used to mark when there was no activity for a set period of time label Sep 20, 2024
@github-actions GitHub Actions
Copy link

Marking issue as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Oct 20, 2024
@catchergeese
Copy link
Author

Bumping this one. In the meantime, Next.js 15 was released with React 19 RC support.

@github-actions github-actions bot removed the stale Used to mark when there was no activity for a set period of time label Oct 24, 2024
@github-actions GitHub Actions
Copy link

Marking issue as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Nov 24, 2024
@catchergeese
Copy link
Author

Still valid.

@github-actions github-actions bot removed the stale Used to mark when there was no activity for a set period of time label Nov 28, 2024
@github-actions GitHub Actions
Copy link

Marking issue as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Dec 29, 2024
@catchergeese
Copy link
Author

The issue still persists.

@github-actions github-actions bot removed the stale Used to mark when there was no activity for a set period of time label Jan 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2025

Marking issue as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale Used to mark when there was no activity for a set period of time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@catchergeese