Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade csm [TOL-2036] #2256

Merged
merged 2 commits into from
Jun 13, 2024
Merged

feat: upgrade csm [TOL-2036] #2256

merged 2 commits into from
Jun 13, 2024

Conversation

2wce
Copy link
Contributor

@2wce 2wce commented Jun 13, 2024 •
edited
Loading

upgrading csm & fixing tests broken by new behaviour in content api added in this ticket. change will be merged as breaking change

@2wce 2wce self-assigned this Jun 13, 2024
@2wce 2wce marked this pull request as ready for review June 13, 2024 15:15
@2wce 2wce requested a review from a team as a code owner June 13, 2024 15:15
mgoudy91
mgoudy91 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@mgoudy91 mgoudy91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I wonder: if this is a breaking change should we see failing tests to reflect that? Thinking it would be nice to have higher confidence when we deploy that it's working the way we want

@2wce
Copy link
Contributor Author

2wce commented Jun 13, 2024

Looks good to me, though I wonder: if this is a breaking change should we see failing tests to reflect that? Thinking it would be nice to have higher confidence when we deploy that it's working the way we want

@mgoudy91 I pushed the upgrade on it's own first in this commit to show that tests will break then i fixed it in the followup commit

@mgoudy91
Copy link
Contributor

Looks good to me, though I wonder: if this is a breaking change should we see failing tests to reflect that? Thinking it would be nice to have higher confidence when we deploy that it's working the way we want

@mgoudy91 I pushed the upgrade on it's own first in this commit to show that tests will break then i fixed it in the followup commit

Ah, my mistake. sounds great, thanks for the update @2wce !

@2wce 2wce merged commit 7d767fe into master Jun 13, 2024
3 checks passed
@2wce 2wce deleted the feat/update-csm branch June 13, 2024 15:40
@2wce 2wce changed the title feat: upgrade csm [] feat: upgrade csm [TOL-2036] Jun 13, 2024
t-col pushed a commit that referenced this pull request Jun 13, 2024
@2wce @t-col
feat: upgrade csm [] (#2256)
fb01fe6 
* upgrade csm to latest

* chore: fix mappings that were broken by csm upgrade
@contentful contentful deleted a comment from contentful-automation bot Jun 13, 2024
@spudly spudly mentioned this pull request Jul 17, 2024
Merged
@brightonsbox brightonsbox mentioned this pull request Jul 19, 2024
Closed
@GurnankCheema GurnankCheema mentioned this pull request Jul 26, 2024
Open
@andrewrlee andrewrlee mentioned this pull request Aug 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-col t-col t-col approved these changes

@mgoudy91 mgoudy91 mgoudy91 approved these changes

@z0al z0al Awaiting requested review from z0al

@YvesRijckaert YvesRijckaert Awaiting requested review from YvesRijckaert

@aodhagan-cf aodhagan-cf Awaiting requested review from aodhagan-cf

Assignees

@2wce 2wce

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2wce @mgoudy91 @t-col