Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove git dependency for package axios. #195

Merged
merged 1 commit into from
Oct 25, 2017

Conversation

drubin
Copy link
Contributor

@drubin drubin commented Oct 25, 2017

@axe312ger introduced this 6326f90

This change broke a bunch of my docker builds that depend on contentful.

This changes it back to simple HTTP interface for fetches packages.

Our docker builder's don't have git and I would prefer not having to add git just for a temporary fix.

The syntax is slightly more verbose but allows dependencies to still be managed by vanilla npm instead of requiring git to be installed and configured.

@axe312ger introduced this contentful@6326f90

This changes it back to simple http interface for fetches packages
Copy link
Contributor

@Khaledgarbaya Khaledgarbaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariobodemann mariobodemann changed the title Remove git dependancy for package axios. Remove git dependency for package axios. Oct 25, 2017
@Khaledgarbaya Khaledgarbaya merged commit 116584d into contentful:master Oct 25, 2017
@drubin drubin deleted the remove-git-depdancy branch October 25, 2017 13:00
@drubin
Copy link
Contributor Author

drubin commented Oct 25, 2017

Thanks for merging this so quickly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants