feat: add EU host support [DANTE-1574] #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silhoue
reviewed
Jun 13, 2024
| }: CreateClientParams & { sequenceKey: string }) => { | ||
| const config = loadRuntimeConfig() | ||
|
|
||
| const { cmaHost, cdnHost } = getHosts(host || config.host || 'api.contentful.com') |
There was a problem hiding this comment.
Do I understand it right that create only uses CDA while apply only uses CMA? It feels a bit weird then to pass api.contentful.com to both. Could we use a similar pattern here as we do with the token and have separate cmaHost and cdaHost params?
There was a problem hiding this comment.
so yes, create uses CDA and apply uses CMA, but in the current setup, we just create an API client that has access to both, I wouldn't necessarily want to change that right now although I see your point that it's not needed to have both APIs for both use cases
mayakarabula
changed the title
Silhoue
approved these changes
Jun 17, 2024
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to pass a
--hostparameter, this then will set CDA and CMA clients to use either US or EU APIs