Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only first occurrence of special char in content type gets escaped #13

Closed
HannesT117 opened this issue Jun 22, 2020 · 5 comments · Fixed by #14
Closed

Only first occurrence of special char in content type gets escaped #13

HannesT117 opened this issue Jun 22, 2020 · 5 comments · Fixed by #14
Labels
released

Comments

@HannesT117
Copy link
Contributor

Hello!

This issue is connected to #11: Since moduleName only uses replace instead of replaceAll, only the first occurrence of a special char in input gets replaced. For example:

Input: "3-0-Test"
Expected: "Type3__0__Test"
Actual: "Type3__0-Test"
@marcolink
Copy link
Collaborator

@HannesT117
Thanks for the catch! If you have time i would be very happy to see a PR for that, if not, i can try to squeeze it in asap.

@HannesT117 HannesT117 mentioned this issue Jun 22, 2020
Merged
@HannesT117
Copy link
Contributor Author

Done :)

@github-actions
Copy link

🎉 This issue has been resolved in version 1.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@marcolink
Copy link
Collaborator

@HannesT117
would be interested to know if everything works now for you :)

@HannesT117
Copy link
Contributor Author

@marcolink yes, the export seems to be successful now, thanks for asking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(export): escape all special chars in module name HannesT117/cf-content-types-generator
2 participants
@marcolink @HannesT117