Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import skeleton for links in v10 types #251

Merged
merged 1 commit into from
Apr 26, 2023
Merged

fix: import skeleton for links in v10 types #251

merged 1 commit into from
Apr 26, 2023

Conversation

veu
Copy link
Collaborator

@veu veu commented Apr 26, 2023 •
edited
Loading

Fixes #249. The v10 renderer provided relative imports for the field type despite only using the skeleton type in links.

Changes

  • Change provided imports from field type to skeleton type in v10 context
  • Simplify imports for the v9 renderer (same as v10 already does)
  • Add tests for both v9 and v10 imports.

marcolink
marcolink approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@marcolink marcolink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@veu veu merged commit ebf85f7 into master Apr 26, 2023
@veu veu deleted the link-import-fix branch April 26, 2023 11:22
@github-actions
Copy link

🎉 This PR is included in version 2.12.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcolink marcolink marcolink approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing imports with --v10 and --out
2 participants
@veu @marcolink