Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support resource link fields #246

Merged
merged 1 commit into from
Apr 21, 2023
Merged

feat: support resource link fields #246

merged 1 commit into from
Apr 21, 2023

Conversation

veu
Copy link
Collaborator

@veu veu commented Apr 19, 2023

Add basic support for ResourceLink fields to address #198 and update contentful.js to v10 because resource link support in v9 is slightly broken.

This version doesn’t add types for content types linked in ResourceLink fields as that would require a bigger change to fetch content types from multiple spaces.

@marcolink
Copy link
Collaborator

Looks great @veu 👍

As I understand it, this is already relying on types coming from contentful@10 - right?
Does that also mean we need to first enable the generator to fully deliver v10 types?

@veu
Copy link
Collaborator Author

veu commented Apr 21, 2023

Fortunately the types it uses and the output are independent. The v10 renderer is almost ready as well.

Copy link
Collaborator

@marcolink marcolink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fair for now to not type the entities from outer space :)

@veu veu merged commit 6b4b721 into contentful-userland:master Apr 21, 2023
@veu veu deleted the resource-links-support branch April 21, 2023 08:14
@github-actions
Copy link

🎉 This PR is included in version 2.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants