diff --git a/pkg/notifications/notifier.go b/pkg/notifications/notifier.go index b9e322e7c..ec313a508 100644 --- a/pkg/notifications/notifier.go +++ b/pkg/notifications/notifier.go @@ -55,6 +55,12 @@ func (n *Notifier) String() string { sb.WriteString(", ") } } + + if sb.Len() < 2 { + // No notification services are configured, return early as the separator strip is not applicable + return "none" + } + names := sb.String() // remove the last separator diff --git a/pkg/notifications/notifier_test.go b/pkg/notifications/notifier_test.go index 5ef75a02e..ecd228f33 100644 --- a/pkg/notifications/notifier_test.go +++ b/pkg/notifications/notifier_test.go @@ -23,6 +23,22 @@ func TestActions(t *testing.T) { } var _ = Describe("notifications", func() { + Describe("the notifier", func() { + When("only empty notifier types are provided", func() { + + command := cmd.NewRootCommand() + flags.RegisterNotificationFlags(command) + + err := command.ParseFlags([]string{ + "--notifications", + "shoutrrr", + }) + Expect(err).NotTo(HaveOccurred()) + notif := notifications.NewNotifier(command) + + Expect(notif.String()).To(Equal("none")) + }) + }) Describe("the slack notifier", func() { builderFn := notifications.NewSlackNotifier