deploy.sh: upload release source tarball #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhem
reviewed
Dec 16, 2016
| @@ -27,6 +27,7 @@ sudo chmod +x /usr/bin/ghr | |||
|
|
|||
| # github release and tag | |||
| echo "Github release..." | |||
| tar cfz dist/traefik-${VERSION}.src.tar.gz --exclude .git --exclude dist . | |||
There was a problem hiding this comment.
options --exclude-vcs --exclude-vcs-ignores are better choices :)
There was a problem hiding this comment.
without --exclude-vcs-ignores if we want to keep /vendor
|
If i'm not wrong, Github is already doing a |
|
@guilhem but this is not the same, it does not include vendor/ with source code of used packages. Having this option allows us to install any release at any point without having to worry that repositories gets vanished at some point. |
|
@Mic92 Ok I understand, it's true I used to commit |
Having a release tarball including all vendor source makes life of maintainers a lot easier to create downstream packages. It also ensures that as long as the go release is available the software can be build reproducible.
|
LGTM 👼 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a release tarball including all vendor source makes life of maintainers a lot easier to create downstream packages.
It also ensures that as long as the go release is available the software can be build reproducible.