Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty path with App-root annotation #4326

Merged
merged 1 commit into from
Dec 26, 2018
Merged

Allow empty path with App-root annotation #4326

merged 1 commit into from
Dec 26, 2018

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented Dec 20, 2018

What does this PR do?

Modifies logic to allow empty paths when used with the app-root annotation

Motivation

Fixes #4322

More

  • Added/updated tests
  • Added/updated documentation - Not needed, intended behavior

@dtomcej dtomcej requested a review from a team as a code owner December 20, 2018 18:32
@traefiker traefiker added this to the 1.7 milestone Dec 20, 2018
dduportal
dduportal approved these changes Dec 20, 2018
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

nmengin
nmengin approved these changes Dec 22, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Dec 26, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 4db0dd9 into traefik:v1.7 Dec 26, 2018
@traefiker traefiker mentioned this pull request Dec 26, 2018
Closed
@ldez ldez mentioned this pull request Jan 8, 2019
Merged
16 tasks
@doctori doctori mentioned this pull request Jan 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@dduportal dduportal dduportal approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/ingress kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@dtomcej @juliens @dduportal @nmengin @ldez @traefiker