Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix partial declaration of authentication. #4212

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Fix partial declaration of authentication. #4212

merged 1 commit into from
Nov 22, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Nov 19, 2018

What does this PR do?

Now, when the partial/invalid auth label is defined (eg. traefik.frontend.auth.foobar) the auth is skipped.

Motivation

Fixes #4211

Stack: goroutine 36 [running]:
github.com/containous/traefik/middlewares.recoverFunc(0x7f0ebb409540, 0xc00000c978, 0xc000117200)
	/go/src/github.com/containous/traefik/middlewares/recover.go:40 +0x1b7
panic(0x21e5ca0, 0x4551d40)
	/usr/local/go/src/runtime/panic.go:513 +0x1b9
github.com/containous/traefik/middlewares/auth.(*Authenticator).ServeHTTP(0xc0003ed820, 0x7f0ebb409540, 0xc00000c980, 0xc000117800, 0xc0003eddc0)
	/go/src/github.com/containous/traefik/middlewares/auth/authenticator.go:161 +0x29
github.com/containous/traefik/vendor/github.com/urfave/negroni.middleware.ServeHTTP(0x2949220, 0xc0003ed820, 0xc0003edae0, 0x7f0ebb409540, 0xc00000c980, 0xc000117800)
	/go/src/github.com/containous/traefik/vendor/github.com/urfave/negroni/negroni.go:33 +0x9c
github.com/containous/traefik/vendor/github.com/urfave/negroni.(*Negroni).ServeHTTP(0xc00018e060, 0x7f0ebb409540, 0xc00000c978, 0xc000117800)
	/go/src/github.com/containous/traefik/vendor/github.com/urfave/negroni/negroni.go:81 +0xee
github.com/containous/traefik/vendor/github.com/containous/mux.(*Router).ServeHTTP(0xc0006708a0, 0x7f0ebb409540, 0xc00000c978, 0xc000117800)
	/go/src/github.com/containous/traefik/vendor/github.com/containous/mux/mux.go:133 +0xf1
github.com/containous/traefik/middlewares.(*HandlerSwitcher).ServeHTTP(0xc0003055c0, 0x7f0ebb409540, 0xc00000c978, 0xc000117300)
	/go/src/github.com/containous/traefik/middlewares/handlerSwitcher.go:24 +0x6f
github.com/containous/traefik/vendor/github.com/urfave/negroni.Wrap.func1(0x7f0ebb409540, 0xc00000c978, 0xc000117300, 0xc0003edda0)
	/go/src/github.com/containous/traefik/vendor/github.com/urfave/negroni/negroni.go:41 +0x4d
github.com/containous/traefik/vendor/github.com/urfave/negroni.HandlerFunc.ServeHTTP(0xc00054b9a0, 0x7f0ebb409540, 0xc00000c978, 0xc000117300, 0xc0003edda0)
	/go/src/github.com/containous/traefik/vendor/github.com/urfave/negroni/negroni.go:24 +0x4e
github.com/containous/traefik/vendor/github.com/urfave/negroni.middleware.ServeHTTP(0x294dee0, 0xc00054b9a0, 0xc00054ba00, 0x7f0ebb409540, 0xc00000c978, 0xc000117300)
	/go/src/github.com/containous/traefik/vendor/github.com/urfave/negroni/negroni.go:33 +0x9c
github.com/containous/traefik/vendor/github.com/urfave/negroni.middleware.ServeHTTP-fm(0x7f0ebb409540, 0xc00000c978, 0xc000117300)
	/go/src/github.com/containous/traefik/vendor/github.com/urfave/negroni/negroni.go:33 +0x60
net/http.HandlerFunc.ServeHTTP(0xc0003edd80, 0x7f0ebb409540, 0xc00000c978, 0xc000117300)
	/usr/local/go/src/net/http/server.go:1964 +0x44
github.com/containous/traefik/middlewares.(*RequestHost).ServeHTTP(0x4592118, 0x7f0ebb409540, 0xc00000c978, 0xc000117200, 0xc0003edd80)
	/go/src/github.com/containous/traefik/middlewares/request_host.go:20 +0x1ec
github.com/containous/traefik/vendor/github.com/urfave/negroni.middleware.ServeHTTP(0x2949020, 0x4592118, 0xc00054b9e0, 0x7f0ebb409540, 0xc00000c978, 0xc000117200)
	/go/src/github.com/containous/traefik/vendor/github.com/urfave/negroni/negroni.go:33 +0x9c
github.com/containous/traefik/vendor/github.com/urfave/negroni.middleware.ServeHTTP-fm(0x7f0ebb409540, 0xc00000c978, 0xc000117200)
	/go/src/github.com/containous/traefik/vendor/github.com/urfave/negroni/negroni.go:33 +0x60
net/http.HandlerFunc.ServeHTTP(0xc0003edd60, 0x7f0ebb409540, 0xc00000c978, 0xc000117200)
	/usr/local/go/src/net/http/server.go:1964 +0x44
github.com/containous/traefik/middlewares.NegroniRecoverHandler.func1(0x7f0ebb409540, 0xc00000c978, 0xc000117200, 0xc0003edd60)
	/go/src/github.com/containous/traefik/middlewares/recover.go:24 +0x87
github.com/containous/traefik/vendor/github.com/urfave/negroni.HandlerFunc.ServeHTTP(0x27143e0, 0x7f0ebb409540, 0xc00000c978, 0xc000117200, 0xc0003edd60)
	/go/src/github.com/containous/traefik/vendor/github.com/urfave/negroni/negroni.go:24 +0x4e
github.com/containous/traefik/vendor/github.com/urfave/negroni.middleware.ServeHTTP(0x294dee0, 0x27143e0, 0xc00054b9c0, 0x7f0ebb409540, 0xc00000c978, 0xc000117200)
	/go/src/github.com/containous/traefik/vendor/github.com/urfave/negroni/negroni.go:33 +0x9c
github.com/containous/traefik/vendor/github.com/urfave/negroni.(*Negroni).ServeHTTP(0xc00058a030, 0x296fe60, 0xc00017ca80, 0xc000117200)
	/go/src/github.com/containous/traefik/vendor/github.com/urfave/negroni/negroni.go:81 +0xee
github.com/containous/traefik/vendor/github.com/containous/mux.(*Router).ServeHTTP(0xc000397d40, 0x296fe60, 0xc00017ca80, 0xc000117200)
	/go/src/github.com/containous/traefik/vendor/github.com/containous/mux/mux.go:133 +0xf1
github.com/containous/traefik/h2c.Server.Serve.func1(0x296fe60, 0xc00017ca80, 0xc000116f00)
	/go/src/github.com/containous/traefik/h2c/h2c.go:78 +0x409
net/http.HandlerFunc.ServeHTTP(0xc00054bc00, 0x296fe60, 0xc00017ca80, 0xc000116f00)
	/usr/local/go/src/net/http/server.go:1964 +0x44
net/http.serverHandler.ServeHTTP(0xc00002b1e0, 0x296fe60, 0xc00017ca80, 0xc000116f00)
	/usr/local/go/src/net/http/server.go:2741 +0xab
net/http.(*conn).serve(0xc0002d1360, 0x2972360, 0xc0004d3500)
	/usr/local/go/src/net/http/server.go:1847 +0x646
created by net/http.(*Server).Serve
	/usr/local/go/src/net/http/server.go:2851 +0x2f5

More

  • Added/updated tests
  • [-] Added/updated documentation

@traefiker traefiker added this to the 1.7 milestone Nov 19, 2018
mmatur
mmatur approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur changed the title fix: partial declaration of authentication. Fix partial declaration of authentication. Nov 20, 2018
jbdoumenjou
jbdoumenjou approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Nov 22, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 479ee9a into traefik:v1.7 Nov 22, 2018
@traefiker traefiker mentioned this pull request Nov 22, 2018
Closed
@ldez ldez deleted the fix/auth branch November 22, 2018 18:05
@juliens juliens mentioned this pull request Nov 26, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/authentication kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @jbdoumenjou @mmatur @traefiker