Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward auth headers #3521

Merged
merged 4 commits into from
Jun 30, 2018
Merged

Forward auth headers #3521

merged 4 commits into from
Jun 30, 2018

Conversation

hwhelan-CB
Copy link
Contributor

@hwhelan-CB hwhelan-CB commented Jun 21, 2018

What does this PR do?

Implement functionality for this feature request: #3515
Based on this commit, and updated since the repos have diverged: drampelt@b10cc88?diff=unified

Motivation

Fixes #3515

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@ldez
Copy link
Contributor

ldez commented Jun 22, 2018

Thanks for your interest in Traefik.

Do you have a real use case where renaming the header is useful?

@hwhelan-CB
Copy link
Contributor Author

I do not have a good use case for this, I was working off the assumption that @drampelt did when he originally implemented this feature.

@ldez
Copy link
Contributor

ldez commented Jun 28, 2018

Could you keep only the "copy header system" based on the header names and delete the rename feature.

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍
LGTM

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@dtomcej
Copy link
Contributor

dtomcej commented Jun 29, 2018

No need to merge master into this branch. Our merge bot does that for us.

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@traefiker traefiker merged commit f9b1106 into traefik:master Jun 30, 2018
@hwhelan-CB hwhelan-CB deleted the forward_auth_headers branch July 9, 2018 14:10
@sumanthjoel

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants