Add more k8s tests #3491
Merged
Add more k8s tests #3491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
status/2-needs-review
kind/enhancement
timoreimann
reviewed
Jun 13, 2018
| os.Setenv("KUBERNETES_SERVICE_HOST", "localhost") | ||
| os.Setenv("KUBERNETES_SERVICE_PORT", "443") | ||
| _, err := p.newK8sClient("") | ||
| os.Clearenv() |
There was a problem hiding this comment.
How about defering the cleanup right after we have set up the custom environment (i.e., right after line 2229)? This would protect us from p.newK8sClient messing up and leaving our fixture in place longer than expected.
Similar below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add and fix existing k8s tests
Motivation
More people using k8s, better tests to assist with refactoring
More