Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend name with docker-compose and segments. #3485

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Backend name with docker-compose and segments. #3485

merged 1 commit into from
Jun 14, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jun 13, 2018

What does this PR do?

Fixes backend name with docker-compose and segments.

Motivation

Fixes #3482

More

  • Added/updated tests

@ldez ldez added the kind/bug/fix a bug fix label Jun 13, 2018
@ldez ldez requested a review from a team as a code owner June 13, 2018 08:34
@traefiker traefiker added this to the 1.6 milestone Jun 13, 2018
@ldez ldez mentioned this pull request Jun 13, 2018
Closed
mmatur
mmatur approved these changes Jun 13, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Jun 13, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

juliens
juliens approved these changes Jun 14, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the fix/backend-name-compose-scale branch from 25a6f4c to 21491ac Compare June 14, 2018 07:04
@traefiker traefiker merged commit bb3f28f into traefik:v1.6 Jun 14, 2018
@ldez ldez deleted the fix/backend-name-compose-scale branch June 14, 2018 12:36
@ldez ldez mentioned this pull request Apr 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/provider/docker kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @mmatur @nmengin @traefiker