Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect changes in catalog healthy nodes in healthCheck watch #3390

Merged
merged 4 commits into from
Jun 5, 2018

Conversation

thebinary
Copy link
Contributor

@thebinary thebinary commented May 25, 2018

What does this PR do?

Resolve issue that "Traefik does not refresh backend list on state change of consul catalog health checks"

Motivation

The list of backends were not being reflected in Traefik with changes in health checks of nodes.

Fixes #3380
Related to #3157

More

  • Added/updated tests

@traefiker traefiker added this to the 1.6 milestone May 25, 2018
@mmatur mmatur force-pushed the consulcatalog-issues branch from 445ecfa to df294e7 Compare May 25, 2018 17:57
@mmatur mmatur self-assigned this May 28, 2018
@mmatur mmatur changed the title reflect changes in catalog healthy nodes in healthCheck watch Reflect changes in catalog healthy nodes in healthCheck watch May 29, 2018
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants