Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes ambiguity with the word 'default' #3344

Merged
merged 1 commit into from
May 18, 2018
Merged

Removes ambiguity with the word 'default' #3344

merged 1 commit into from
May 18, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented May 17, 2018 •
edited
Loading

What does this PR do?

Rename segment labels.

Motivation

Removes ambiguity with the word 'default'

More

  • Added/updated documentation

@traefiker traefiker added this to the 1.6 milestone May 17, 2018
@ldez ldez changed the title Removes ambiguity on the word 'default' Removes ambiguity with the word 'default' May 17, 2018
mmatur
mmatur approved these changes May 17, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes May 17, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

juliens
juliens approved these changes May 18, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the fix/acme-userguide branch from b9655f9 to 457c7f6 Compare May 18, 2018 14:40
@traefiker traefiker merged commit 1db5fcf into traefik:v1.6 May 18, 2018
@ldez ldez deleted the fix/acme-userguide branch May 18, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/docker kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @mmatur @dtomcej @traefiker