Typo in documentation #3261
Merged
Typo in documentation #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/documentation
status/2-needs-review
kind/bug/fix
dtomcej
suggested changes
May 7, 2018
docs/index.md
Outdated
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| Træfik is a modern HTTP reverse proxy and load balancer that makes deploying microservices easy. | |||
| Træfik integrates with your existing infrastructure components ([Docker](https://www.docker.com/), [Swarm mode](https://docs.docker.com/engine/swarm/), [Kubernetes](https://kubernetes.io), [Marathon](https://mesosphere.github.io/marathon/), [Consul](https://www.consul.io/), [Etcd](https://coreos.com/etcd/), [Rancher](https://rancher.com), [Amazon ECS](https://aws.amazon.com/ecs), ...) and configures itself automatically and dynamically. | |||
| Telling Træfik where your orchestrator is could be the _only_ configuration step you need to do. | |||
| Telling Træfik where your orchestrator should be the _only_ configuration step you need to do. | |||
There was a problem hiding this comment.
Not sure I agree with this change. How about:
Pointing Træfik at your orchestrator should be the _only_ configuration step you need.?
There was a problem hiding this comment.
We'll also have to update the README.md file accordingly.
|
I've made those changes, let me know if there's anything else. |
m3co-code
approved these changes
May 8, 2018
ldez
approved these changes
May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes
is couldtoshouldin the documentationMotivation
It bothered me, I had to read the sentence twice because it was phrased weird.