Check for endpoints while detecting Consul service changes #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/enhancement
|
@caseycs The review process: https://github.com/containous/traefik/blob/master/MAINTAINER.md#pr-review-process Please don't merge master. |
|
@ldez thanks, I missed this part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Check for endpoint ip address while detecting Consul catalog changes
Motivation
I'm experimenting with Docker Swarm, Registrator and Consul to implement service discovery in my project, and turned out, that scaling or updating an image for a service does not trigger Traefik to refresh back-ends.
After some investigation I figured out, that it's looking only on diff of unique node ids (that's why scaling a service on the same node never trigger update) and does not check for endpoint ip changes at all.
More
Additional Notes
Nothing else to mention.