Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in examples #2446

Merged
merged 1 commit into from
Nov 22, 2017
Merged

Fix typo in examples #2446

merged 1 commit into from
Nov 22, 2017

Conversation

dahefanteng
Copy link
Contributor

What does this PR do?

Just fix typo issue,try to avoid mislead others.

@@ -64,7 +64,7 @@ function insert_etcd3_data() {

function show_usage() {
echo "USAGE : etcd-config.sh ETCD_API_VERSION [ETCD_IP_ADDRESS]"
echo " ETCD_API_VERSION : Values v2 or V3 (v3 requires ETCD_IP_ADDRESS)"
echo " ETCD_API_VERSION : Values V2 or V3 (v3 requires ETCD_IP_ADDRESS)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you could also replace v3 requires ETCD_IP_ADDRESS by V3 requires ETCD_IP_ADDRESS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right,I have replaced that.

@ldez ldez added kind/enhancement a new or improved feature. and removed contributor/waiting-for-corrections labels Nov 22, 2017
@ldez ldez changed the title Fix typo Fix typo in examples Nov 22, 2017
@ldez ldez added this to the 1.5 milestone Nov 22, 2017
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants