Make the traefik.port label optional when using service labels in Docker containers. #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
contributor/waiting-for-corrections
status/2-needs-review
and removed
status/0-needs-triage
labels
nmengin
force-pushed
the
hotfix/service-label-port
branch
from
79db19e to
c7ef6a3
Compare
ldez
force-pushed
the
hotfix/service-label-port
branch
from
bd8d883 to
831e01d
Compare
traefiker
approved these changes
Oct 30, 2017
nmengin
force-pushed
the
hotfix/service-label-port
branch
from
831e01d to
21ac7a7
Compare
traefiker
force-pushed
the
hotfix/service-label-port
branch
from
21ac7a7 to
c62ad2e
Compare
This was referenced Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All Docker containers which use
service labelswith no value for thecontainer labelnamedtraefik portare filtered.This PR fixes this problem.
Fixes : #1321 #1840