Add missing functions for ECS template #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldmantaiter
force-pushed
the
fix-ecs-template
branch
3 times, most recently
from
ea6fb44 to
a92b9ef
Compare
oldmantaiter
force-pushed
the
fix-ecs-template
branch
from
a92b9ef to
9097e9f
Compare
|
Looks like Semaphore is having some issues (docker not running, hosts rebooting), gonna push another and hopefully it goes through. EDIT: Totally not having issues, I was misunderstanding the host reboot, it is really from failing gofmt (sorry for all the CI noise) |
oldmantaiter
force-pushed
the
fix-ecs-template
branch
3 times, most recently
from
9b48ee4 to
7d4a7b8
Compare
ldez
suggested changes
Oct 24, 2017
provider/ecs/ecs.go
Outdated
| "hasStickinessLabel": p.hasStickinessLabel, | ||
| "getStickinessCookieName": p.getStickinessCookieName, | ||
| // generateECSConfig fills the config template with the given instances | ||
| func (p *Provider) generateECSConfig(services map[string][]ecsInstance, ecsFuncMap template.FuncMap) (*types.Configuration, error) { |
There was a problem hiding this comment.
Could you explains ecsFuncMap? It's always nil...
There was a problem hiding this comment.
For ease of testing. I wanted to be able to have a failure case, but I see that is useless now. I will change.
oldmantaiter
force-pushed
the
fix-ecs-template
branch
from
7d4a7b8 to
aa626af
Compare
- Some functions were missing, this adds them to the function map passed into the template loader - Adds testing around generating ECS configuration - This regression was added in traefik#2050
oldmantaiter
force-pushed
the
fix-ecs-template
branch
from
aa626af to
4c59c6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
map passed into the template loader
When using ECS, on Traefik start these messages appear in the logs: