Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github.com/xenolf/lego to 0.4.1 #2304

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Update github.com/xenolf/lego to 0.4.1 #2304

merged 1 commit into from
Oct 31, 2017

Conversation

oldmantaiter
Copy link
Contributor

  • Mainly to be able to use the AWS_HOSTED_ZONE_ID to give the zone ID
    for a private zone
  • Also fixes glide dependency problem where github.com/pyr/egoscale, a
    dependency of lego, reorganized its repo structure, moving everything from
    src/egoscale to the root of the repository

@ldez
Copy link
Contributor

ldez commented Oct 23, 2017 •
edited
Loading

@oldmantaiter thanks for the contribution 👍

Do you authorize me to fix your PR?

@ldez
Copy link
Contributor

ldez commented Oct 23, 2017

If you want to do it by yourself: you must update only the required dependencies.

@oldmantaiter
Copy link
Contributor Author

@ldez - Is this a limitation of using Glide? And I assume I must manually edit the glide.lock and glide.yaml files to only include updates for the dependencies of this package?

@ldez
Copy link
Contributor

ldez commented Oct 24, 2017 •
edited
Loading

Glide always update all dependencies, but we don't want that.

To explains very quickly how to do:

  • make a ./script/glide.sh update
  • revert each non required line.
  • revert vendor
  • make a ./script/glide.sh install

@oldmantaiter
Copy link
Contributor Author

Ok. I figured and much and just did that and pushed, waiting on semaphore now.

@oldmantaiter
Copy link
Contributor Author

@ldez - Looks like that did the trick, I'm going to run some tests to ensure the lego functionality I am looking for works as expected.

@oldmantaiter
Copy link
Contributor Author

While testing I noticed a regression from another PR (#2050) - I'll fix that one first. There are template functions that are not defined in the function map.

@ldez ldez added this to the 1.5 milestone Oct 25, 2017
@oldmantaiter oldmantaiter force-pushed the update-lego branch 2 times, most recently from 4a2070d to b37acdb Compare October 25, 2017 14:20
ldez
ldez reviewed Oct 25, 2017
View reviewed changes
glide.lock Outdated
hash: 90d53da9a6eaba85d524d95410051ff7f12b1f76181df2ad4796b2439f3a2a37
updated: 2017-10-24T14:08:11.364720581+02:00
hash: 70e3ed39d2777d36b679ff55b8b0f2eb8d0b239fdfb8108f41b8b7239bc7920c
updated: 2017-10-25T10:18:20.438135-04:00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove extra spaces?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

ldez
ldez approved these changes Oct 25, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oldmantaiter oldmantaiter force-pushed the update-lego branch 2 times, most recently from 5e47ef1 to f688e0b Compare October 25, 2017 17:22
nmengin
nmengin approved these changes Oct 30, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oldmantaiter @traefiker
Update github.com/xenolf/lego to 0.4.1
dfe3e43 
- Mainly to be able to use the `AWS_HOSTED_ZONE_ID` to give the zone ID
  for a private zone
- Also fixes glide dependency problem where [github.com/pyr/egoscale](https://github.com/pyr/egoscale), a
  dependency of lego, reorganized its repo structure, moving everything from
  `src/egoscale` to the root of the repository
@traefiker traefiker merged commit e8d63b2 into traefik:master Oct 31, 2017
@mmatur mmatur mentioned this pull request Oct 31, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@emilevauge emilevauge emilevauge approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/acme kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@oldmantaiter @ldez @emilevauge @nmengin @traefiker