Enable loadbalancer.sticky for Consul Catalog #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbonneval
changed the title
ldez
added
area/provider/consul
area/sticky-session
kind/enhancement
ldez
changed the title
nmengin
reviewed
Aug 18, 2017
There was a problem hiding this comment.
@nbonneval Many thanks for this PR.
Just a question, in the directory example, there is a compose file which allows to create a Docker consul container (compose-consul.yml) and a shell script which executes HTTP requests to this container(consul-config.sh).
Do you think this file has to be updated in the way to add request to the sticky attribute?
|
@nmengin Never thought about it, but why not. I did think about adding specific tests in provider/consul/consul_catalog_test.go though, but never took time to do it... |
nmengin
requested changes
Aug 21, 2017
There was a problem hiding this comment.
@nbonneval Thank you for your feedback.
I think it can be nice to add it.can you do it?
Specific test should be great! 😉
emilevauge
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As commented by my colleague dwarfaz in the issue #1575, we added support for the backend.loadbalancer.sticky tag with consul_catalog by editing the provider's template.
It now always creates the backend's loadbalancer configuration section, with default values if nothing's specified, but supports changing both the load balancing method and the sticky flag.
In order to synchronize with other providers' capabilities & doc, I'd prefer the existing tag (backend.loadbalancer) to be renamed to backend.loadbalancer.method, but it would break existing configurations