-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
traefik controller access to secrets #1707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah,i think this pr should be merged,some people fix this issue themeselves
I wonder if we should formulate this in a more conditional manner. Presumably, secrets access will only be required by those that actually use basic authentication? |
Answering myself:
Sadly, Traefik does not conditionally watch for secrets as of now. See also #1784. So this one seems okay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM as an example that should work in all cases.
In practice if I were paranoid I would probably use a more granular rule here:
- apiGroups: [""]
resources: ["secrets"]
resourceNames: ["name-of-a-secret"]
verbs: ["get","list","watch"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The traefik controller shall have access to secrets for the k8s basic authentication (traefik#1488) to work
The traefik controller shall have access to secrets for the k8s basic authentication (#1488) to work