Exported getSubDomain function from Marathon provider #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds fair to me. Any concerns, @vdemeester or @emilevauge? |
timoreimann
added
kind/enhancement
timoreimann
approved these changes
May 31, 2017
|
@vdemeester can you formally approve? |
|
@aantono in the meantime, could you update the branch? |
…se in custom templates
aantono
force-pushed
the
expose-marathon-subDomain-template-function
branch
from
b1eaae9 to
54e4bed
Compare
|
Done |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating custom template for Marathon provider, it really helps to have a
getSubDomainfunction be available to use in custom templates. Otherwise the logic to compute the sub-domain directly inside the template gets very messy, and reusing the same logic as the provider would help with consistency.