Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify naming of toolbox images #373

Closed
HarryMichal opened this issue Feb 7, 2020 · 2 comments
Closed

Simplify naming of toolbox images #373

HarryMichal opened this issue Feb 7, 2020 · 2 comments
Labels
2. Images Images for creating toolbox containers 5. Help Wanted Extra attention is needed 7. Need Information Further information is requested

Comments

@HarryMichal
Copy link
Member

In the Dockerfiles of toolbox images we set the label name like this: name="$FGC/$NAME". That leads to the fact that the images are called in case of Fedora 31 like this: f31/fedora-toolbox. This naming schema is not right in my opinion. All these images are a fedora-toolbox with one difference and that is the version. But version should be handled by the version label.

I propose we change the naming to just: fedora-toolbox and use the label to manage versions. We could also start offering Rawhide as fedora-toolbox:rawhide.

@HarryMichal HarryMichal added 5. Help Wanted Extra attention is needed 2. Images Images for creating toolbox containers 7. Need Information Further information is requested labels Sep 10, 2020
@debarshiray
Copy link
Member

This was fixed in #615

Until recently, the FGC namespace used to be required by the Fedora container guidelines.

@debarshiray
Copy link
Member

I propose we change the naming to just: fedora-toolbox and
use the label to manage versions. We could also start offering
Rawhide as fedora-toolbox:rawhide.

At the least, we shouldn't refer to the images as rawhide, until the code knows how to interpret the string rawhide.

Beyond that, using rawhide to label the images might increase the amount of manual intervention that's necessary when a new Fedora release gets branched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. Images Images for creating toolbox containers 5. Help Wanted Extra attention is needed 7. Need Information Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants