Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"RepoTags" in directory transport miessed #245

Closed
hustcat opened this issue Nov 7, 2016 · 7 comments
Closed

"RepoTags" in directory transport miessed #245

hustcat opened this issue Nov 7, 2016 · 7 comments

Comments

@hustcat
Copy link

hustcat commented Nov 7, 2016

RepoTags in directory transport miessed:

# skopeo inspect dir:busybox-dir  
{
    "Digest": "sha256:29f5d56d12684887bdfa50dcd29fc31eea4aaf4ad3bec43daf19026a7ce69912",
    "RepoTags": [],
    "Created": "2016-10-07T21:03:58.469866982Z",
    "DockerVersion": "1.12.1",
    "Labels": {},
    "Architecture": "amd64",
    "Os": "linux",
    "Layers": [
        "sha256:56bec22e355981d8ba0878c6c2f23b21f422f30ab0aba188b54f1ffeff59c190"
    ]
}
@mtrmac
Copy link
Contributor

mtrmac commented Nov 7, 2016

RepoTags does not make any sense for dir: . It is a list of all tags in the repository (not a list of tags applicable to the image), and dir is not a tag mapping management system; the only identification of an image in dir: is the directory path.

In fact RepoTags does not really fit skopeo inspect for a docker: image either (it is a property of the repository, not of the inspected image), we are leaving it around only for backward compatibility.

What are you really trying to find out about the image?

@hustcat
Copy link
Author

hustcat commented Nov 8, 2016

I just think busybox-dir means a repository directory, it may be contain mutiple tags

@mtrmac
Copy link
Contributor

mtrmac commented Nov 8, 2016

That’s not how dir: works: it doesn’t even ask for a tag anywhere, after all. Only the path identifies an image, and $dir/manifest.json is the image manifest. There is no naming system, and, no facility for storing multiple images in a single directory; uploading a new image into the same directory overwrites manifest.json, making the old image inaccessible.

dir: has really been created as a debugging/testing tool; currently it is not supposed to be a full-featured replacement for a "real” container image repository server.

@runcom
Copy link
Member

runcom commented Nov 8, 2016

dir: has really been created as a debugging/testing tool; currently it is not supposed to be a full-featured replacement for a "real” container image repository server.

just want to echo this. dir: is just for debugging and we do not plan to make it a full featured transport like the other (real)

@rhatdan
Copy link
Member

rhatdan commented Nov 8, 2016

Why not add ostree:PATH?

@mtrmac
Copy link
Contributor

mtrmac commented Nov 8, 2016

Looking at #155, it is not clear to me how the pieces are ultimately supposed to fit together for @hustcat .

ostree: might be useful for #242 though.

@mtrmac
Copy link
Contributor

mtrmac commented May 10, 2017

The core of the request, RepoTags for dir:, does not reflect how dir: actually works. Please file a separate issue if anything else (multi-image OCI index support?) is needed.

@mtrmac mtrmac closed this as completed May 10, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants