From c318b304bad8175cefc7987a0a00661671f52dcf Mon Sep 17 00:00:00 2001 From: Chris Evich Date: Thu, 4 Mar 2021 11:50:54 -0500 Subject: [PATCH] Fix images_test using inconsistent alpine:latest At some point, somehow the `quay.io/libpod/apline:latest` image changed. This is causing some integration tests to fail on this branch. Mainly these failures are caused by missed-expectations w/ the test image. Fix these test by using a specific, fixed, named image tag instead of 'latest' (which can change unpredictably). Signed-off-by: Chris Evich --- test/e2e/images_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/e2e/images_test.go b/test/e2e/images_test.go index 281b2c313c..cb259750fe 100644 --- a/test/e2e/images_test.go +++ b/test/e2e/images_test.go @@ -188,23 +188,23 @@ WORKDIR /test }) It("podman images filter since image", func() { - dockerfile := `FROM quay.io/libpod/alpine:latest + dockerfile := `FROM quay.io/libpod/alpine:3.2 ` podmanTest.BuildImage(dockerfile, "foobar.com/before:latest", "false") result := podmanTest.Podman([]string{"images", "-q", "-f", "since=quay.io/libpod/alpine:latest"}) result.WaitWithDefaultTimeout() Expect(result).Should(Exit(0)) - Expect(len(result.OutputToStringArray())).To(Equal(7)) + Expect(len(result.OutputToStringArray())).To(Equal(8)) }) It("podman image list filter after image", func() { - dockerfile := `FROM quay.io/libpod/alpine:latest + dockerfile := `FROM quay.io/libpod/alpine:3.2 ` podmanTest.BuildImage(dockerfile, "foobar.com/before:latest", "false") result := podmanTest.Podman([]string{"image", "list", "-q", "-f", "after=quay.io/libpod/alpine:latest"}) result.WaitWithDefaultTimeout() Expect(result).Should(Exit(0)) - Expect(result.OutputToStringArray()).Should(HaveLen(7), "list filter output: %q", result.OutputToString()) + Expect(result.OutputToStringArray()).Should(HaveLen(8), "list filter output: %q", result.OutputToString()) }) It("podman images filter dangling", func() {