Add console mode to podman machine #18820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
do-not-merge/work-in-progress
jakecorrenti
changed the title
jakecorrenti
force-pushed
the
add-console-to-mac-machine
branch
3 times, most recently
from
59aedb7 to
76c0546
Compare
jakecorrenti
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, jakecorrenti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
baude
reviewed
Jun 19, 2023
|
one small change, else LGTM |
jakecorrenti
force-pushed
the
add-console-to-mac-machine
branch
from
76c0546 to
1258e49
Compare
|
@baude PTAL |
Add the functionality for a console to be dipslayed when the user runs `podman --log-level debug machine start` on MacOS. This mimics the behavior that currently exists on Linux. [NO NEW TESTS NEEDED] Signed-off-by: Jake Correnti <[email protected]>
jakecorrenti
force-pushed
the
add-console-to-mac-machine
branch
from
1258e49 to
65e5d27
Compare
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the functionality for a console to be dipslayed when the user runs
podman --log-level debug machine starton MacOS. This mimics the behavior that currently exists on Linux.Associated with: crc-org/vfkit#44
Does this PR introduce a user-facing change?