podman.spec: recommend slirp4netns

[vrothberg]

Fixes: #1234
Signed-off-by: Valentin Rothberg [email protected]

[vrothberg]

@rhatdan PTAL. I picked up the low hanging fruit from #1234 (comment). As slirp4netns is already packaged for Fedora, I assume the change is okay.

[rhatdan]

Can you put this into the same block above. So on RHEL it Requires else it recommends.

[Conan-Kudo]

It doesn't exist in RHEL, so it should just be conditioned for "not-RHEL", since Fedora, SLE, openSUSE, and others all support weak dependencies.

[rhatdan]

Well it will exist in RHEL8. But I am fine with just moving it up with the ifdef block.

[vrothberg]

I moved the line in the if branch, so it'll affect Fedora. Once it's packaged in RHEL, it can be added to the else branch.

[giuseppe]

thanks for working on this. LGTM

[rhatdan]

Does SUSE support Recommends yet?

[vrothberg]

Does SUSE support Recommends yet?

It does but we're not using this .spec for packaging.

[Conan-Kudo]

Perhaps as a separate PR, we should consider enhancing the packaging so that it can be tested in COPR against Fedora, EL7, openSUSE Leap 15.0, and openSUSE Tumbleweed.

[rhatdan]

Yes that was what I was thinking. The goal of the spec, I believe it to allow random people to use it for their distribution.

We don't use this spec for Fedora or RHEL or Centos, but we use something close to it. (I wish it was closer.)

[rhatdan]

THis should be

%if 0%{?fedora}
Recommends: container-selinux
Recommends: slirp4netns
%else
Requires: container-selinux
Requires: slirp4netns
%endif

[Conan-Kudo]

I'd flip it to the following:

%if 0%{?rhel} && 0%{?rhel} < 8
Requires: container-selinux
Requires: slirp4netns
%else
Recommends: container-selinux
Recommends: slirp4netns
%endif

[rhatdan]

I agree, the rhel will handle centos as well.

[vrothberg]

Updated, thanks!

[giuseppe]

bot, retest this please

[rhatdan]

@rh-atomic-bot r+

[rhatdan]

@rh-atomic-bot retry

[rhatdan]

I am just going to merge since this passes all tests and Humu seems to not like it.