Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman network connect should support setting a static ip and mac #9883

Closed
Luap99 opened this issue Mar 30, 2021 · 16 comments
Closed

podman network connect should support setting a static ip and mac #9883

Luap99 opened this issue Mar 30, 2021 · 16 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. network Networking related issue or feature

Comments

@Luap99
Copy link
Member

Luap99 commented Mar 30, 2021

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind feature

Description

It is currently not possible to set a static ip or mac for a second network. You can only use --ip and --mac with podman run/create. podman network connect should also allow --ip and --mac to set the IP and MAC address for the new network.
This should be possible with CNI. The more challenging problem is how we store the ip and mac address currently. It is stored as single entry per container with such a change we would need to store it per container network.

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 30, 2021
@Luap99
Copy link
Member Author

Luap99 commented Apr 1, 2021

@mheon What do you think about the db structure, could you implement this? I am pretty sure I can make the cni part happen.

@mheon
Copy link
Member

mheon commented Apr 1, 2021

I think it's doable, but complicated. We'll need to deprecate the existing Static IP and Static MAC configuration in the DB (respect it if already configured and don't allow network connect to set static IPs on this containers, but stop generating it from now on) and move to a map of network name to static IP / static MAC and any other configuration information necessary. The DB functions for storing networks a container is joined to currently return a []string of just network names, but we should be able to patch them to return a map including this additional configuration information without much trouble.

@github-actions
Copy link

github-actions bot commented May 2, 2021

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented May 2, 2021

@Luap99 Are you planning on looking at this?

@Luap99
Copy link
Member Author

Luap99 commented May 3, 2021

I think @mheon is currently working on the db structure.

@github-actions
Copy link

github-actions bot commented Jun 3, 2021

A friendly reminder that this issue had no activity for 30 days.

@Luap99
Copy link
Member Author

Luap99 commented Jun 3, 2021

@mheon Have you started working on this?

@Luap99 Luap99 removed the stale-issue label Jun 3, 2021
@mheon
Copy link
Member

mheon commented Jun 3, 2021

Yep, but I put it down ~two weeks ago and have not found time to pick it back up. I'll try and pick it back up next week.

@Luap99 Luap99 added the network Networking related issue or feature label Jun 21, 2021
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Jul 22, 2021

@Luap99 @mheon Any update on this one?

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Sep 23, 2021

@Luap99 @mheon What is going on with this one?

@Luap99
Copy link
Member Author

Luap99 commented Sep 23, 2021

This is planed for 4.0

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. network Networking related issue or feature
Projects
None yet
Development

No branches or pull requests

4 participants