-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run --rmi? [feature] to clean extracted container image #4628
Comments
This sounds like a great enhancement to me. In case the image is being used by another container, I suggest to ignore the error that it couldn't be removed. |
Agree. Do we also want to restrict it so we only remove the image if it was not already present? |
Since @onlyjob brought up the Idea, I will let him answer it. I personally could go either way. |
Thanks. I think implementation should carefully check if image is being used but always remove unused images even if they existed before. Extracted image is just a "cache" and when user explicitly requests to drop cache with |
Sounds reasonable. @onlyjob Would you be interested in adding a PR? |
Of course you've asked for PR, as always. :) I'm not qualified and have no time to implement even if I could... No funding either... |
If you don't ask, you never know if someone will say yes. Thanks for the suggestion. |
@rhatdan I want to take up this issue. |
Thanks! I assigned the issue to you. Feel free to reach out here or on the #podman channel on Freenode if you have any questions. |
Excellent @bipuladh Looking forward to the PR. |
This issue had no activity for 30 days. In the absence of activity or the "do-not-close" label, the issue will be automatically closed within 7 days. |
Being worked on, I believe |
A friendly reminder that this issue had no activity for 30 days. |
@bipuladh, did you find time to look into this issue? |
@vrothberg I stopped because there is a PR #4772 that works on this issue. |
Sorry for not noticing earlier! I dropped a comment that already assigned issues should not be picked up without communicating it. |
@bipuladh I am really sorry that I missed your comment asking to work on this. If you want you can continue working from where I stopped (I don't mind mentoring you if you need help). @vrothberg this wasn't intentionally and I'm really sorry. I know it's my fault that I didn't read the thread carefully but may I suggest adding the "assigned" tag to issues so I could filter unassigned issues? Again, I feel bad and am sorry. If there is anything I can do to fix this, let me know. |
That's an honest mistake, which can happen. Don't worry, @boaz0! I think you should continue working on it, given there's already the open PR.
Did you have a look at GitHub search syntax (see below)? I believe it's possible to look for unassigned issues. Anyhow, even a label still requires to read the issue and the comments. |
@vrothberg - that's actually cool, I didn't know Github has its own search syntax. |
@boaz0 Are you still working on this, or did it get merged? |
@rhatdan still working on this - close to completion |
I'll try and do a final review in prep for merge after lunch |
I'm running the following command for the first time:
And after execution an extracted image is left behind:
It would be great to have an option like
--rmi
to clean-up such unpacked/pulled image.Thanks.
The text was updated successfully, but these errors were encountered: