make install.catatonic is not arch friendly

[baude]

make install.catatonit is not going to work on any arch other than x86_64 because it appears to be pulling a compiled binary for x86_64. We need an arch friendly way of dealing with this.

[tobwen]

export GOPATH="$HOME/go"
catatonit_src="openSUSE/catatonit"
          src="$GOPATH/src/github.com/$catatonit_src"
       target="$GOPATH/podman/"

[ -d "$GOPATH" ] || mkdir -p "$GOPATH"
[ -d "$src" ]    || mkdir -p "$src"
[ -d "$target" ] || mkdir -p "$target"

cd "$target"
( git clone --depth=1 "https://github.com/$catatonit_src" "$src" && \
  cd src && autoreconf -i && ./configure && make && make install DESTDIR=$target )

[baude]

sure, but frankly i am struggling with this a little. it is clearly a dependency and I find it a bit unusual having dependencies installed like this. thoughts?

[afbjorklund]

I built it from source. Not sure why it defaults to binary, or why not just add it as a dependency ?

Added these steps, to the above:

eval `grep ^CATATONIT_VERSION hack/install_catatonit.sh`

in libpod

git checkout $CATATONIT_VERSION

in catatonit

Also had to patch the location in (libpod.conf and libpod/runtime.go), since it had been hardcoded.

[afbjorklund]

@tobwen : catatonit is a C program. it looks a little odd in a Go directory ?

[vrothberg]

I suggest cloning catatonit into a tmp directory, build it there, copy it to the CATATONIT_PATH, and remove the directory.

[tobwen]

@afbjorklund Sure, this is just my podman rendering stack, where anything _GO_es into: https://gist.github.com/tobwen/25a010d3b90a6491e5646c0e77163557

[baude]

Why isn't it just a dep like runc or conmon

[rhatdan]

Someone would need to package it up and get it into Fedora/RHEL/Centos. Currently we are just using this as an internal tool of podman.

[vrothberg]

@lsm5 has a card for that but more important things keep popping up.

[tobwen]

@rhatdan For what do you use it? I often don't compile it at all. I thought, it's PID 1 for the container when activated?

[afbjorklund]

Maybe it needs to be in a separate package because of licensing issues ? (GPLv3+, vs. ASL 2.0)

I just added it for completeness (i.e. run --init), using tini for the actual container examples...

[tobwen]

Boy, that escalated quickly...

https://github.com/yetanothergeek/bbinit
https://github.com/catatonit
https://github.com/Yelp/dumb-init
https://github.com/troglobit/finit
https://github.com/krallin/tini

[rhatdan]

@lsm5 Any movement on this? Has anyone else worked on it?

[baude]

@rhatdan @vrothberg what should we do here? i believe this is still an issue

[baude]

ping @vrothberg ideas?

[vrothberg]

ping @vrothberg ideas?

I am cool with using tini for CI. catatonit isn't packaged for Fedora yet and tini should be available everywhere.

[baude]

we need to get an answer here ... what is required to not do what we are doing?

[vrothberg]

@baude, we can either clone the repository and build it or we download the pre-built binaries from https://github.com/krallin/tini/releases.

I prefer cloning and building catatonit. Will look into this tomorrow morning to warmup.