Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish API UNIX socket for Windows Podman machines #23408

Closed
arixmkii opened this issue Jul 26, 2024 · 3 comments · Fixed by #23409
Closed

Publish API UNIX socket for Windows Podman machines #23408

arixmkii opened this issue Jul 26, 2024 · 3 comments · Fixed by #23409
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@arixmkii
Copy link
Contributor

Feature request description

Right now Podman machines on Windows publish 2 named pipes - one Podman specific and another one Docker compatible (if it is available). Named pipes are still the go to way for exposing non TCP connections under Windows, but as AF_UNIX (https://devblogs.microsoft.com/commandline/af_unix-comes-to-windows/) support has become a more commonly used feature on Windows it would be useful to add this as well. Curl tool bundled with Windows can access UNIX sockets, so, the examples from API docs would become relevant for Windows users and it will allow writing different sorts of automation using shell scripting + curl tool.

Suggest potential solution

Add publishing of additional endpoint to gvproxy and win-sshproxy command lines, the transport is already supported need to only add the command line arguments.

According to this https://endoflife.date/windows it could potentially cause issues for still supported Win 10 1507 and Win 10 1607, as all other still supported builds has its baseline above 17063 (the introduction of AF_UNIX) to Windows. I think it would be already an issue to have Podman machines running on such old Windows builds.

In case if it still considered necessary to support environments w/o AF_UNIX this could be put behind feature toggle added to settings, but this feature toggle would become less and less relevant going forward and as this change will not land before 5.3.0 it might not be reasonable to support very old OS versions with edge version of Podman.

Have you considered any alternatives?

Continue to publish only named pipes, which could be used for automation and use podman machine ssh to use curl to access API (which is less convenient, but would work for many cases).

Additional context

No response

@arixmkii arixmkii added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 26, 2024
@arixmkii
Copy link
Contributor Author

I will create a PR for this functionality.

Copy link

A friendly reminder that this issue had no activity for 30 days.

@arixmkii
Copy link
Contributor Author

Not really stale, just lack of activity here. :) It has PR and is being worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant