Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement QEMU version testing inside Podman code #18314

Closed
arixmkii opened this issue Apr 23, 2023 · 6 comments
Closed

Implement QEMU version testing inside Podman code #18314

arixmkii opened this issue Apr 23, 2023 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. machine

Comments

@arixmkii
Copy link
Contributor

Feature request description

Sometimes to implement a feature it is needed to have new QEMU version. It was first encountered in #17473 (comment) where fresh QEMU version was needed for implementing cross platform support for Windows OS. While other targets could just rely on older code, they also could benefit from the new codebase, which in turn would allow to phase out code supporting older versions, when minimal supported QEMU version is bumped.

Suggest potential solution

Podman could inspect the output of help commands of QEMU to first collect information on what version is available and even check for specific features as well. Similar thing is implemented in Lima project https://github.com/lima-vm/lima/blob/b03835df403f806e37e56cbf95cc1b8728e91749/pkg/qemu/qemu.go#L183

Have you considered any alternatives?

Defining minimal baseline, but it is difficult as QEMU will always be a moving target and Podman has to support LTS Linux targets, where QEMU version is frozen, but only backported fixes are provided (no features are normally backported).

Additional context

No response

@arixmkii arixmkii added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 23, 2023
@baude
Copy link
Member

baude commented Apr 23, 2023

this approach of having a matrix of features that do or don't work is something that would drive me nuts (a claim most people have said already happened). Nevertheless, perhaps setting a minimal version would work? As in, if you have x.y, we hard fail.

@arixmkii
Copy link
Contributor Author

In my opinion, just checking the version for some sort of feature level is just fine, but hard fail is not an option at least for the feature in question #17473, because we just can't hard fail for the feature, which would still be valid for older installations. And the minimal version of 7.2.0, will be possible only after RHEL 10 baseline I believe, but I'm not aware for how long newer versions of Podman are published for older RHEL versions.

For now this issue if more sort of RFC. I don't know if the project has a practice, where such issues are prefixed with RFC, I can update the title then.

@Luap99 Luap99 added the machine label Apr 28, 2023
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Jul 28, 2023

@cevich I think there has been some movement on this?

@cevich
Copy link
Member

cevich commented Jul 28, 2023

Yes, I believe we spoke about it during the planning meeting this week. Jira cards are being crafted.

@arixmkii
Copy link
Contributor Author

Now that minimal QEMU version is raised to 7.2.0 with Machine 5, this could be delayed and reintroduced, when any new APIs of interest are discovered for machine improvements.

@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label May 28, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. machine
Projects
None yet
Development

No branches or pull requests

5 participants