Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quadlet - add UserNS key that may be passed as is to run or kube play #17984

Closed
ygalblum opened this issue Mar 30, 2023 · 6 comments · Fixed by #18098
Closed

Quadlet - add UserNS key that may be passed as is to run or kube play #17984

ygalblum opened this issue Mar 30, 2023 · 6 comments · Fixed by #18098
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet

Comments

@ygalblum
Copy link
Contributor

Feature request description

The current implementation divides the argument that will eventually be passed to --userns to different parameters. As a result, any change in the possible values might require changes in Quadlet. In addition, it can cause a proliferation of supported keys.

Before implementing this, we need to decide how to handle backward compatibility

Suggest potential solution

A clear and concise description of what you want to happen.

Have you considered any alternatives?

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@ygalblum ygalblum added kind/feature Categorizes issue or PR as related to a new feature. quadlet labels Mar 30, 2023
@ygalblum
Copy link
Contributor Author

I opened this issue instead of continuing the discussion on the closed PR #17961

@vrothberg
Copy link
Member

vrothberg commented Mar 30, 2023

I am in favor of adding UserNS and deprecate the other fields. From a RHEL perspective, Quadlet is still tech-preview so there are no backwards guarantees until GA.

@vrothberg
Copy link
Member

@giuseppe @rhatdan PTAL

@giuseppe
Copy link
Member

same for me. Let's keep it simple and map directly to UserNS

@rhatdan
Copy link
Member

rhatdan commented Apr 1, 2023

I agree, the other keys just confuse me, and if people are going back and forth, I don't see the value in breaking it up.

@xduugu
Copy link
Contributor

xduugu commented Apr 7, 2023

I've created a pull request for the new key. Since it deprecates the Remap keys, it would be great if it could be included in v4.5

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants