Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

play kube override with {tcp,udp} should keep {other} from YAML #17101

Closed
edsantiago opened this issue Jan 13, 2023 · 1 comment · Fixed by #17102
Closed

play kube override with {tcp,udp} should keep {other} from YAML #17101

edsantiago opened this issue Jan 13, 2023 · 1 comment · Fixed by #17102
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

New e2e test flake:

Expected
      <*net.OpError | 0xc000de49b0>: {
          Op: "read",
          Net: "udp",
          Source: <*net.UDPAddr | 0xc00142ae70>{IP: [127, 0, 0, 1], Port: 43120, Zone: ""},
          Addr: <*net.UDPAddr | 0xc00142aea0>{IP: [127, 0, 0, 1], Port: 19012, Zone: ""},
          Err: <*poll.DeadlineExceededError | 0x1fc1a20>{},
      }
  to be nil

@ygalblum PTAL

@ygalblum
Copy link
Contributor

Testing a loopback over a UDP connection is not reliable enough for testing. I've change the implementation to use inspect instead of actually sending data. I think it's enough to assume that if the ports are listed correctly in the inspect, the ports are in fact open, right?

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants