Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Kube Play: add support for Job #17011

Closed
ygalblum opened this issue Jan 5, 2023 · 13 comments · Fixed by #23722
Closed

[Feature]: Kube Play: add support for Job #17011

ygalblum opened this issue Jan 5, 2023 · 13 comments · Fixed by #23722
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. kube locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@ygalblum
Copy link
Contributor

ygalblum commented Jan 5, 2023

Feature request description

Currently, podman supports pods and deployments. While pod is the base element, K8S users will usually not deploy pods. Instead, they will deploy deployments for long lasting workloads and jobs for single shot operations.
When using systemd, the behavior of jobs seems to be a better fit as it will not have Podman monitor the pods but instead pass the monitoring and hence the handling of the restart policy to systemd.
For example, the supported valued for restartPolicy for containers in a Job are only Never or OnFailure. So, a default restartPolicy of Never, with parallelism and completions set to 1 will result in propagating the exit status of the pod to systemd, letting it decide whether or not the service should be restarted (depending on the restart policy of the systemd unit)

Suggest potential solution

Passing a job to podman kube play will result in running the containers listed in the Pod specification

Have you considered any alternatives?

As explained, the user may use deployments or pods directly. But, it will not provide the same experience

Additional context

While the trigger for this feature request is Quadlet and systemd, podman will directly benefit from this added support as well

@ygalblum ygalblum added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 5, 2023
@rhatdan
Copy link
Member

rhatdan commented Jan 5, 2023

Makes sense to me.

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

A friendly reminder that this issue had no activity for 30 days.

@ygalblum
Copy link
Contributor Author

ygalblum commented Feb 7, 2023

/stale remove

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Mar 15, 2023

@umohnani8 PTAL

@umohnani8 umohnani8 self-assigned this May 2, 2023
@fsdrw08
Copy link

fsdrw08 commented Jul 1, 2023

any updates?

@umohnani8
Copy link
Member

A design doc has been created for this and it is on the to do list, targeting this for 4.7.

@mrgleeco
Copy link

mrgleeco commented Aug 3, 2023

link to design doc / discussions?

@adelton
Copy link
Contributor

adelton commented Apr 18, 2024

@umohnani8 Could you please show the link to the design doc?

@fsdrw08
Copy link

fsdrw08 commented May 30, 2024

any updates?

@umohnani8
Copy link
Member

Yup, I have a WIP in PR - will clean it up and open a PR by next week.

@jaimehrubiks
Copy link

This makes a lot of sense. I believe podman is getting a lot of attention in HPC, I myself find it very flexible and simple for rootless use cases, where developers test their own containers, and in many cases they then send them to kubernetes. For HPC, jobs are the most common kubernetes yaml.

@rhatdan
Copy link
Member

rhatdan commented Jul 24, 2024

@umohnani8 Still have the PR? Maybe someone else can take it over?

@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 6, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. kube locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants