Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker system helper / podman-mac-helper installation should be setup by default on macOS #16547

Closed
benoitf opened this issue Nov 18, 2022 · 4 comments · Fixed by #16565
Closed
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. podman-desktop

Comments

@benoitf
Copy link
Contributor

benoitf commented Nov 18, 2022

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind feature

Description

Today, if I install podman and start a podman machine
I can read in the output that the Docker socket is not added as I need to setup an extra tool.

something like

The system helper service is not installed; the default Docker API socket
address can't be used by podman. If you would like to install it run the
following commands:

        sudo /opt/podman/bin/podman-mac-helper install
        podman machine stop; podman machine start

But as the pkg installer is performing installation steps as root, I think that it should also install the mac helper
so we don't need a post-install step.

On Windows the docker socket is automatically bound, while on macOS it requires this extra step.

Steps to reproduce the issue:

  1. Run brew or pkg installation of podman

Describe the results you received:

need to run install as root on podman-mac-helper

Describe the results you expected:

podman-mac-helper installation already done

Additional information you deem important (e.g. issue happens only occasionally):

Output of podman version:

(paste your output here)

Output of podman info:

(paste your output here)

Package info (e.g. output of rpm -q podman or apt list podman or brew info podman):

(paste your output here)

Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/main/troubleshooting.md)

Yes/No

Additional environment details (AWS, VirtualBox, physical, etc.):

@benoitf benoitf added macos MacOS (OSX) related podman-desktop labels Nov 18, 2022
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 18, 2022
@github-actions github-actions bot removed the macos MacOS (OSX) related label Nov 18, 2022
@rhatdan
Copy link
Member

rhatdan commented Nov 18, 2022

@gbraad Can this be done within the installer, where if you don't have root passwd, it will still install, or if not, could you set it up such that a user could cancel the attempt to install the docker system helper but still successfully install.

@gbraad
Copy link
Member

gbraad commented Nov 18, 2022

^^^ @anjannath WDYT?

@anjannath
Copy link
Member

anjannath commented Nov 20, 2022 via email

@n1hility
Copy link
Member

n1hility commented Dec 2, 2022

Brew based installs of podman can't do this by default, package installation is purposefully not ran as root, and packages are supposed to indicate root actions as a separate step. So the best we could do is after a brew install is complete, print directions, but these may be ignored.

I agree we should fix the mac installer case, but in the brew case, I think the only solution is if podman-desktop checks and activates it (or tells the user to)

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. podman-desktop
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants