Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Add --dry-run mode on kube play command/REST API #15903

Closed
benoitf opened this issue Sep 22, 2022 · 9 comments
Closed

RFE: Add --dry-run mode on kube play command/REST API #15903

benoitf opened this issue Sep 22, 2022 · 9 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. kube locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. podman-desktop

Comments

@benoitf
Copy link
Contributor

benoitf commented Sep 22, 2022

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind feature

Description

podman kube play command is applying a subset of supported elements from a kubernetes YAML file.
so it might be good to know in advance what will be done, elements that will be skipped, etc before applying the command as we may not want to proceed this command depending on the supported items

Describe the results you expected:
--dry-run option on CLI/REST API to be able to check what would be done so we can better track/notify/report the user to what will be done

Additional information you deem important (e.g. issue happens only occasionally):

#15902 is more important

Output of podman version:

(paste your output here)

Output of podman info:

(paste your output here)

Package info (e.g. output of rpm -q podman or apt list podman):

(paste your output here)

Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/main/troubleshooting.md)

Yes/No

Additional environment details (AWS, VirtualBox, physical, etc.):

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 22, 2022
@rhatdan
Copy link
Member

rhatdan commented Sep 22, 2022

@umohnani8 PTAL

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@github-actions
Copy link

github-actions bot commented Dec 9, 2022

A friendly reminder that this issue had no activity for 30 days.

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Jan 18, 2023

quadlet --dryrun was just added. #16926

@vyasgun
Copy link
Member

vyasgun commented May 4, 2023

/assign

@vrothberg
Copy link
Member

vrothberg commented May 4, 2023

@vyasgun, please wait before opening a PR/starting to work on it.

@containers/podman-maintainers, I am a bit afraid of --dry-run making the kube-code even more spaghetti-ish. I think it's time to think about refactoring the code into a single package; currently the code is scattered over multiple packages and (IMO very) hard to read.

I am personally not a fan of a --dry-run flag as it will add permanent costs: with each new supported field, we (potentially) had to update what's being created and how and add tests for it. Quadlet is a different story as it is a generator where a --dry-run flag is cheap and easy to implement with no future maintenance costs.

As @benoitf mentions above, #15902 is more important.

@rhatdan
Copy link
Member

rhatdan commented Aug 22, 2023

I don't see this moving forward, I think fixing progress info on pull is the best we can do. Closing.

@rhatdan rhatdan closed this as completed Aug 22, 2023
@baude
Copy link
Member

baude commented Aug 22, 2023

for the sake of history, can you perhaps show what the output of the command would look like?

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. kube locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. podman-desktop
Projects
None yet
Development

No branches or pull requests

6 participants