Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Expose system reset to the API / remote CLI #15886

Closed
benoitf opened this issue Sep 21, 2022 · 7 comments
Closed

RFE: Expose system reset to the API / remote CLI #15886

benoitf opened this issue Sep 21, 2022 · 7 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. podman-desktop

Comments

@benoitf
Copy link
Contributor

benoitf commented Sep 21, 2022

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind feature

Description

Sometimes, podman machine is not working as expected. One example is #15526
But to call podman system reset we need first to ssh into the machine which is not so convenient for users.

Steps to reproduce the issue:

  1. podman machine ssh

  2. podman system reset

Describe the results you received:

2 steps

Describe the results you expected:

Add a REST API to call the reset command.
It will allow tools like Podman Desktop to add a reset machine option

in addition a podman machine reset would help end users.

Additional information you deem important (e.g. issue happens only occasionally):

Output of podman version:

4.2.1

Output of podman info:

(paste your output here)

Package info (e.g. output of rpm -q podman or apt list podman):

(paste your output here)

Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/main/troubleshooting.md)

Yes/No

Additional environment details (AWS, VirtualBox, physical, etc.):

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 21, 2022
@ashley-cui
Copy link
Member

Is this a good idea? I feel like allowing users to reset settings from another machine via an API (think in non podman-machine scenarios) feels dangerous. I'd much rather have podman machine do a podman machine ssh podman system reset (as a singular command, as podman machine ssh takes args).

@rhatdan
Copy link
Member

rhatdan commented Sep 28, 2022

That makes sense to me. We are not allowing most/all podman system * objects to be manipulated via a remote API.

@rhatdan rhatdan closed this as completed Sep 28, 2022
@mheon
Copy link
Member

mheon commented Sep 29, 2022

The request from the desktop team was a way to "factory reset" a VM that is having problems. In that context, it seems reasonable to expose some way to do this - unless we want to require something like podman machine ssh podman system reset

@ashley-cui
Copy link
Member

I'd be okay with something like a podman machine reset command, but that would literally just be a wrapper around podman machine ssh podman system reset, which seems like a reasonable command to just run from desktop

@baude
Copy link
Member

baude commented Sep 29, 2022

what does factory reset mean? the contents of the vm are reset or the vm itself is reset?

@benoitf
Copy link
Contributor Author

benoitf commented Sep 29, 2022

From a 'Client' point of view, after the reset, everything should work again and it includes data loss.

It may include a podman reset or a vm reset as well. (Sometimes podman machine is not starting anymore so podman machine ssh will hang as well as the machine is not responding)

so it may be:
if machine is responding: try to to do the system reset
if machine is not responding: wipe content or reinit it.

@rhatdan
Copy link
Member

rhatdan commented Sep 29, 2022

It might be safer to destroy the VM and recreate it rather then just reset the container storage.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. podman-desktop
Projects
None yet
Development

No branches or pull requests

5 participants