Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digest could be invalid when using multiple registries #15652

Closed
janisz opened this issue Sep 6, 2022 · 6 comments
Closed

Digest could be invalid when using multiple registries #15652

janisz opened this issue Sep 6, 2022 · 6 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@janisz
Copy link

janisz commented Sep 6, 2022

/kind bug

Description

Reported RepoDigests are invalid when pulling image from more than one registry.
podman does cross product of image names and all available digests which can lead to invalid repo digests as digest is registry specific.

Similar to: cri-o/cri-o#6208

Steps to reproduce the issue:

  1. Pull the same image from two registries

  2. Inspect images and their repo digests

Describe the results you received:

          "Id": "2b7d6430f78d432f89109b29d88d4c36c868cdbf15dc31d2132ceaa02b993763",
          "Digest": "sha256:f8fe7d0e6be40a7febbdec9aaf820eed7dbe62cb2afff00f67610666f7a9bd97",
          "RepoTags": [
               "docker.io/library/nginx:1.23",
               "image-registry.openshift-image-registry.svc:5000/rox-12400/nginx:1.23"
          ],
          "RepoDigests": [
               "docker.io/library/nginx@sha256:89020cd33be2767f3f894484b8dd77bc2e5a1ccc864350b92c53262213257dfc",
               "docker.io/library/nginx@sha256:b95a99feebf7797479e0c5eb5ec0bdfa5d9f504bc94da550c2f58e839ea6914f",
               "docker.io/library/nginx@sha256:f8fe7d0e6be40a7febbdec9aaf820eed7dbe62cb2afff00f67610666f7a9bd97",
               "image-registry.openshift-image-registry.svc:5000/rox-12400/nginx@sha256:89020cd33be2767f3f894484b8dd77bc2e5a1ccc864350b92c53262213257dfc",
               "image-registry.openshift-image-registry.svc:5000/rox-12400/nginx@sha256:b95a99feebf7797479e0c5eb5ec0bdfa5d9f504bc94da550c2f58e839ea6914f",
               "image-registry.openshift-image-registry.svc:5000/rox-12400/nginx@sha256:f8fe7d0e6be40a7febbdec9aaf820eed7dbe62cb2afff00f67610666f7a9bd97"
          ],

Describe the results you expected:

Docker output

        "Id": "sha256:2b7d6430f78d432f89109b29d88d4c36c868cdbf15dc31d2132ceaa02b993763",
        "RepoTags": [
            "nginx:1.23",
            "quay.io/dhaus/repro:1.23"
        ],
        "RepoDigests": [
            "nginx@sha256:89020cd33be2767f3f894484b8dd77bc2e5a1ccc864350b92c53262213257dfc",
            "nginx@sha256:b95a99feebf7797479e0c5eb5ec0bdfa5d9f504bc94da550c2f58e839ea6914f",
            "quay.io/dhaus/repro@sha256:89020cd33be2767f3f894484b8dd77bc2e5a1ccc864350b92c53262213257dfc"
        ],
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 6, 2022
@janisz
Copy link
Author

janisz commented Sep 6, 2022

/cc @dhaus67

janisz referenced this issue Sep 6, 2022
Generate an image's RepoDigests list using all applicable digests, and
refrain from outputting a digest in the tag column of the "images"
output.

Signed-off-by: Nalin Dahyabhai <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Sep 6, 2022

@mtrmac @vrothberg @nalind PTAL

@mtrmac
Copy link
Collaborator

mtrmac commented Sep 6, 2022

#3761 (comment)

@vrothberg
Copy link
Member

@mtrmac can we close this as a duplicate?

@mtrmac
Copy link
Collaborator

mtrmac commented Sep 7, 2022

Let’s. (I don’t have a strong opinion on which one to close — keeping the full context of #3761 seems valuable, OTOH this one is a concise description of a specific problem, without the debugging session, and without other people piling on with not-exactly-the-same issues.)

@vrothberg
Copy link
Member

Closing as a duplicate of #3761.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

No branches or pull requests

4 participants