Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: lint flake?? #15590

Closed
edsantiago opened this issue Sep 1, 2022 · 5 comments
Closed

CI: lint flake?? #15590

edsantiago opened this issue Sep 1, 2022 · 5 comments
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

Seen just now in one of my PRs:

cmd/podman/pods/ps.go:214:40: directive `//nolint:revive,stylecheck` is unused for linter "revive" (nolintlint)
func (l ListPodReporter) Id() string { //nolint:revive,stylecheck
                                       ^
cmd/podman/pods/ps.go:228:45: directive `//nolint:revive,stylecheck` is unused for linter "revive" (nolintlint)
func (l ListPodReporter) InfraId() string { //nolint:revive,stylecheck
                                            ^
make: *** [Makefile:247: golangci-lint] Error 1

None of these lines has changed in months. lint hasn't changed (AFAICT). Test passed on Re-run. I don't understand what can cause a lint flake, but filing as a heads-up and placeholder should it start happening often.

@edsantiago edsantiago added the flakes Flakes from Continuous Integration label Sep 1, 2022
@Luap99
Copy link
Member

Luap99 commented Sep 8, 2022

It had this problem yesterday locally. Very likely a bug in the linter. I guess it is time to update the linter anyway maybe this got fixed.

@edsantiago
Copy link
Member Author

But how can it be a flake? I tend to expect the linter to be deterministic given the same linter, same checked-out tree.

Then again #15488 is a flake, too, and it shouldn't be. I'm starting to suspect that some of our CI boots are different from others.

@Luap99
Copy link
Member

Luap99 commented Sep 8, 2022

I don't know either, FYI I gave up updating the linter for now. Way to many changes required to make it work.

@github-actions
Copy link

github-actions bot commented Oct 9, 2022

A friendly reminder that this issue had no activity for 30 days.

@vrothberg
Copy link
Member

The linter has been bumped since then, so I am going to close it assuming it was a fart in earlier/older version.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

No branches or pull requests

3 participants