Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"--passwd-entry" Type Flag For /etc/group #14965

Closed
p0da opened this issue Jul 19, 2022 · 11 comments · Fixed by #17450
Closed

"--passwd-entry" Type Flag For /etc/group #14965

p0da opened this issue Jul 19, 2022 · 11 comments · Fixed by #17450
Assignees
@boaz0
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@p0da
Copy link

p0da commented Jul 19, 2022

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind feature

Description

Currently podman has a --passwd-entry flag which allows users to specify/customize the entry that is appended to /etc/passwd file. Would it be possible to also include a --group-entry flag to do the same thing for the /etc/group file?
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 19, 2022
@giuseppe
Copy link
Member

--group-entry makes sense to have.

Would you like to open a PR to add the feature?

@p0da
Copy link
Author

p0da commented Jul 19, 2022 •
edited
Loading

Unfortunately I am not familiar enough with go make an attempt at it.

@rhatdan
Copy link
Member

rhatdan commented Jul 20, 2022

How are you testing this? What command is blowing up?

@giuseppe
Copy link
Member

it is not an issue but a feature request, we have --passwd-entry but we do not have --group-entry

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@cdoern cdoern self-assigned this Aug 22, 2022
@rhatdan rhatdan added Good First Issue This issue would be a good issue for a first time contributor to undertake. and removed stale-issue labels Aug 22, 2022
@boaz0
Copy link
Collaborator

boaz0 commented Sep 13, 2022

@cdoern mind if I try my luck and work on it?

@rhatdan
Copy link
Member

rhatdan commented Sep 13, 2022

@boaz0 Go for it.

@rhatdan rhatdan assigned boaz0 and unassigned cdoern Sep 13, 2022
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@boaz0
Copy link
Collaborator

boaz0 commented Oct 17, 2022

still working on it...

@KR411-prog
Copy link

@boaz0 are you still working on this? or shall I try this?

@danishprakash danishprakash mentioned this issue Feb 9, 2023
Merged
@danishprakash
Copy link
Contributor

I've tried taking a shot at this, @boaz0 if you're still actively looking into this, feel free to close the PR.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@boaz0 boaz0

Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

create: add entry to /etc/group via --group-entry danishprakash/podman
7 participants
@giuseppe @rhatdan @boaz0 @KR411-prog @danishprakash @cdoern @p0da