Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted logging output in API Bindings package #12204

Closed
b177y opened this issue Nov 7, 2021 · 1 comment
Closed

Unwanted logging output in API Bindings package #12204

b177y opened this issue Nov 7, 2021 · 1 comment
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@b177y
Copy link

b177y commented Nov 7, 2021

In pkg/bindings/containers/containers.go there is an instance of logrus.Infof

logrus.Infof("Going to start container %q", nameOrID)

which I assume was put there during development and was accidentally left in, as none of the other bindings seem to produce any output.

@flouthoc
Copy link
Collaborator

flouthoc commented Nov 8, 2021

Hi @b177y I think you are correct but this on a Info level added in #7451 and I don't think it is doing any harm in fact it seems to be okay for Info purpose ? If it is causing any troubles from usage perspective I'd request moving it to Debug.

But honestly I don't think its causing any harm. So i am closing this one but please feel free to move it to debug if you think its a better option 😄

@flouthoc flouthoc closed this as completed Nov 8, 2021
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

No branches or pull requests

2 participants