Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate kube: do not print spec.containers.ports.protocol: TCP #11965

Closed
dilyanpalauzov opened this issue Oct 14, 2021 · 1 comment · Fixed by #11980
Closed

generate kube: do not print spec.containers.ports.protocol: TCP #11965

dilyanpalauzov opened this issue Oct 14, 2021 · 1 comment · Fixed by #11980
Assignees
@umohnani8
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@dilyanpalauzov
Copy link
Contributor

dilyanpalauzov commented Oct 14, 2021 •
edited
Loading 

$ kube generate kube <ID>
apiVersion: v1 
kind: Pod 
spec:
  containers:
    ports:
    - containerPort: 3890
      hostPort: 3890
      protocol: TCP
…

The default for containers.ports.protocol is TCP, https://v1-18.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#containerport-v1-core. So there is no point to generate protocol: TCP.
@dilyanpalauzov dilyanpalauzov changed the title generate kube -s: do not print spec.containers.ports.protocol: TCP generate kube: do not print spec.containers.ports.protocol: TCP Oct 14, 2021
@rhatdan
Copy link
Member

rhatdan commented Oct 14, 2021

@umohnani8 PTAL

@rhatdan rhatdan added the Good First Issue This issue would be a good issue for a first time contributor to undertake. label Oct 14, 2021
@umohnani8 umohnani8 self-assigned this Oct 14, 2021
@umohnani8 umohnani8 mentioned this issue Oct 14, 2021
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@umohnani8 umohnani8

Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not add TCP to protocol in generated kube yaml umohnani8/libpod
3 participants
@rhatdan @dilyanpalauzov @umohnani8