Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadlink in https://docs.podman.io/en/latest/markdown/podman-machine.1.html #11583

Closed
dilyanpalauzov opened this issue Sep 15, 2021 · 13 comments
Closed
Assignees
Labels
documentation Issue or fix is in project documentation In Progress This issue is actively being worked by the assignee, please do not work on this at this time. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@dilyanpalauzov
Copy link
Contributor

https://docs.podman.io/en/latest/markdown/podman-machine.1.html shows a link (in the middle):

podman-machine-init(1) → https://docs.podman.io/en/latest/markdown/podman-machine-init.1.md

The destination does not exist

@Luap99
Copy link
Member

Luap99 commented Sep 15, 2021

Links inside tables do not work, see ryanfox/sphinx-markdown-tables#18

Feel free to try and find a way to make it work.

@Luap99 Luap99 added the documentation Issue or fix is in project documentation label Sep 15, 2021
@rhatdan
Copy link
Member

rhatdan commented Sep 15, 2021

It looks like all the code needs to do is substitute the *.md with *.html, and it would work?

@rhatdan
Copy link
Member

rhatdan commented Sep 15, 2021

Do we have tools that generate this or does it happen elsewhere?
@TomSweeneyRedHat PTAL

@TomSweeneyRedHat
Copy link
Member

This is interesting. I ran into this about 10 days ago, but then couldn't find this page with the bad links again.

If you go to https://docs.podman.io, and then click on the "Commands" link on the left side of the page, you'll get to: https://docs.podman.io/en/latest/Commands.html. If you then scroll down on that commands page and click on the "machine" link, it takes you to: https://docs.podman.io/en/latest/machine.html. The links on this page work fine and there is no table displayed. (https://docs.podman.io/en/latest/markdown/podman-machine-init.1.html)

The difference is the "markdown" directory is part of the link that you provided for the machine page. (https://docs.podman.io/en/latest/markdown/podman-machine.1.html )

@dilyanpalauzov , do you recall how you got to that particular podman-machine page? I'm thinking we have a bad link somewhere that I'd like to track down. All of this is auto-generated for us, but we may be able to tweak things.

Thanks for sending this along, I thought I just had a bad cache on my browser last weekend as I couldn't replicate, now I'm thinking we might have something to fix.

@TomSweeneyRedHat TomSweeneyRedHat self-assigned this Sep 15, 2021
@TomSweeneyRedHat TomSweeneyRedHat added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Sep 15, 2021
@dilyanpalauzov
Copy link
Contributor Author

I asked Google for “podman machine”.

@rhatdan
Copy link
Member

rhatdan commented Sep 16, 2021

Yup #2 link on google "podman machine" is
https://docs.podman.io/en/latest/markdown/podman-machine.1.html
Which has the bad links.

@Luap99
Copy link
Member

Luap99 commented Sep 16, 2021

Again, every table on docs.podman.io contains broken links , the sphinx-markdown-tables extension is used to convert the markdown tables to html.

extensions = ["sphinx_markdown_tables", "recommonmark"]

The extension does not convert links. I looked at this before but did not find a easy solution in a timely manner.

@rhatdan
Copy link
Member

rhatdan commented Sep 16, 2021

Well I think this should be raised in priority, since the first page anyone goes to from google has broken links.

Could we do something like
ryanfox/sphinx-markdown-tables#18 (comment)

And just post process the html and sed all html://.*md -> html://.*html

@rhatdan
Copy link
Member

rhatdan commented Sep 17, 2021

Man pages are all straightened out now. Check them out.

@rhatdan rhatdan closed this as completed Sep 17, 2021
@TomSweeneyRedHat
Copy link
Member

@dilyanpalauzov thanks again for the issue report and the follow-up. It made it a lot easier for us to track it down.

@lanctot
Copy link

lanctot commented Aug 23, 2022

And just post process the html and sed all html://.*md -> html://.*html

Hi @rhatdan, is this the solution you chose? (I'm having the same problem in our project.) If so, do you have a working configuration of a sphinx build on Read the Docs? I'm having issues trying this solution, but only on Read the Docs, details here: https://stackoverflow.com/questions/73455350/how-to-modify-documentation-built-with-sphinx-via-a-script-in-readthedocs-build

Edit: just found your remote-docs script and links-to-html scripts. Looks like you're building them via pandoc, rather than using sphinx (?), so probably won't be much help in my case.. but if you have any ideas for me I'd appreciate them more things to try! :)

@Luap99
Copy link
Member

Luap99 commented Sep 5, 2022

@lanctot
Copy link

lanctot commented Sep 5, 2022

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Issue or fix is in project documentation In Progress This issue is actively being worked by the assignee, please do not work on this at this time. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

No branches or pull requests

5 participants