Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

healthcheck status should be suffix to podman ps status field #11527

Closed
jwhonce opened this issue Sep 10, 2021 · 2 comments · Fixed by #11609
Closed

healthcheck status should be suffix to podman ps status field #11527

jwhonce opened this issue Sep 10, 2021 · 2 comments · Fixed by #11609
Assignees
@sankalp-r
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. volunteers-wanted Issues good for community/volunteer contributions

Comments

@jwhonce
Copy link
Member

jwhonce commented Sep 10, 2021

For compatibility, the podman ps should include the healthcheck status in the Status field when the container has been configured with a healthcheck.

Expected output:

$ podman ps
CONTAINER ID  IMAGE  STATUS                  NAMES
d53529ca4c93  fedora Up 4 minutes (healthy)  sweet_potato

Actual output:

$ podman ps
CONTAINER ID  IMAGE  STATUS        NAMES
d53529ca4c93  fedora Up 4 minutes  sweet_potato

This is as of podman 3.1.2.
I assume this will require database changes to store the last healthcheck run.
@mheon
Copy link
Member

mheon commented Sep 12, 2021

We already store recent HCs (podman inspect will show details) so this shouldn't be difficult.

@jwhonce jwhonce added Good First Issue This issue would be a good issue for a first time contributor to undertake. volunteers-wanted Issues good for community/volunteer contributions labels Sep 13, 2021
@sankalp-r
Copy link
Contributor

@jwhonce @mheon
I would like to work on this issue.
Can you please guide me to the right direction?

@sankalp-r sankalp-r mentioned this issue Sep 16, 2021
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sankalp-r sankalp-r

Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. volunteers-wanted Issues good for community/volunteer contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added healthcheck to ps command sankalp-r/podman
3 participants
@jwhonce @mheon @sankalp-r