The basic network config is not updated on non-default network

[afbjorklund]

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

When using a custom network, instead of the default "podman" network, the basic info is empty.

Steps to reproduce the issue:

1. sudo podman network create test

2. sudo podman run --network test -d busybox sleep 3600

3. sudo podman container inspect <id_from_previous>

Originally seen in kubernetes/minikube#11293

Describe the results you received:

        "NetworkSettings": {
            "EndpointID": "",
            "Gateway": "",
            "IPAddress": "",
            "IPPrefixLen": 0,
            "IPv6Gateway": "",
            "GlobalIPv6Address": "",
            "GlobalIPv6PrefixLen": 0,
            "MacAddress": "",
            "Bridge": "",
            "SandboxID": "",
            "HairpinMode": false,
            "LinkLocalIPv6Address": "",
            "LinkLocalIPv6PrefixLen": 0,
            "Ports": {},
            "SandboxKey": "/run/netns/cni-a96b5a52-8393-70da-b0e5-54ec25cd0708",
            "Networks": {
                "test": {
                    "EndpointID": "",
                    "Gateway": "10.89.0.1",
                    "IPAddress": "10.89.0.2",
                    "IPPrefixLen": 24,
                    "IPv6Gateway": "",
                    "GlobalIPv6Address": "",
                    "GlobalIPv6PrefixLen": 0,
                    "MacAddress": "7e:5c:18:be:67:c9",
                    "NetworkID": "test",
                    "DriverOpts": null,
                    "IPAMConfig": null,
                    "Links": null
                }
            }
        },

Describe the results you expected:

        "NetworkSettings": {
            "EndpointID": "",
            "Gateway": "10.89.0.1",
            "IPAddress": "10.89.0.2",
            "IPPrefixLen": 24,
            "IPv6Gateway": "",
            "GlobalIPv6Address": "",
            "GlobalIPv6PrefixLen": 0,
            "MacAddress": "7e:5c:18:be:67:c9",
            "Bridge": "",
            "SandboxID": "",
            "HairpinMode": false,
            "LinkLocalIPv6Address": "",
            "LinkLocalIPv6PrefixLen": 0,
            "Ports": {},
            "SandboxKey": "/run/netns/cni-a96b5a52-8393-70da-b0e5-54ec25cd0708",
            "Networks": {
                "test": {
                    "EndpointID": "",
                    "Gateway": "10.89.0.1",
                    "IPAddress": "10.89.0.2",
                    "IPPrefixLen": 24,
                    "IPv6Gateway": "",
                    "GlobalIPv6Address": "",
                    "GlobalIPv6PrefixLen": 0,
                    "MacAddress": "7e:5c:18:be:67:c9",
                    "NetworkID": "test",
                    "DriverOpts": null,
                    "IPAMConfig": null,
                    "Links": null
                }
            }
        },

Additional information you deem important (e.g. issue happens only occasionally):

There seems to be a line missing, when not using the default network.

                settings.InspectBasicNetworkConfig = basicConfig

Output of podman version:

Version:      3.1.2
API Version:  3.1.2
Go Version:   go1.15.2
Built:        Thu Jan  1 01:00:00 1970
OS/Arch:      linux/amd64

Output of podman info --debug:

(paste your output here)

Package info (e.g. output of rpm -q podman or apt list podman):

podman/unknown,now 100:3.1.2-1 amd64 [installed]

Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/master/troubleshooting.md)

Yes

Additional environment details (AWS, VirtualBox, physical, etc.):

Physical Ubuntu

[Luap99]

I think this was done intentionally because docker does the same. @mheon Do you remember?

[afbjorklund]

I think this was done intentionally because docker does the same.

That seems to be true, unfortunately it was on a different code path...

        if ociBin == Docker {
                return dockerNetworkInspect(name)
        }
        if ociBin == Podman {
                return podmanNetworkInspect(name)
        }

We will change our code to use the docker version (with Networks).

The version for podman worked, before we added private networks...

[mheon]

@Luap99 is correct, this is for Docker compat - but I should verify that it's actually what Docker does, it's been a while since I had a proper look at that.