From fed4ef09ce606194dab4052c47b85476654e91e3 Mon Sep 17 00:00:00 2001 From: Brent Baude Date: Wed, 20 May 2020 14:57:30 -0500 Subject: [PATCH] enable pod_create remote integration tests Signed-off-by: Brent Baude --- pkg/api/handlers/compat/containers_start.go | 3 +-- .../handlers/compat/{container_start.go => containers_stop.go} | 0 test/e2e/pod_create_test.go | 2 -- 3 files changed, 1 insertion(+), 4 deletions(-) rename pkg/api/handlers/compat/{container_start.go => containers_stop.go} (100%) diff --git a/pkg/api/handlers/compat/containers_start.go b/pkg/api/handlers/compat/containers_start.go index 9cb1492fb3..cdbc8ff76d 100644 --- a/pkg/api/handlers/compat/containers_start.go +++ b/pkg/api/handlers/compat/containers_start.go @@ -33,7 +33,6 @@ func StartContainer(w http.ResponseWriter, r *http.Request) { utils.ContainerNotFound(w, name, err) return } - state, err := con.State() if err != nil { utils.InternalServerError(w, err) @@ -43,7 +42,7 @@ func StartContainer(w http.ResponseWriter, r *http.Request) { utils.WriteResponse(w, http.StatusNotModified, "") return } - if err := con.Start(r.Context(), false); err != nil { + if err := con.Start(r.Context(), len(con.PodID()) > 0); err != nil { utils.InternalServerError(w, err) return } diff --git a/pkg/api/handlers/compat/container_start.go b/pkg/api/handlers/compat/containers_stop.go similarity index 100% rename from pkg/api/handlers/compat/container_start.go rename to pkg/api/handlers/compat/containers_stop.go diff --git a/test/e2e/pod_create_test.go b/test/e2e/pod_create_test.go index 2f86776cc8..24bfa69ce5 100644 --- a/test/e2e/pod_create_test.go +++ b/test/e2e/pod_create_test.go @@ -84,7 +84,6 @@ var _ = Describe("Podman pod create", func() { }) It("podman create pod without network portbindings", func() { - Skip(v2remotefail) name := "test" session := podmanTest.Podman([]string{"pod", "create", "--name", name}) session.WaitWithDefaultTimeout() @@ -100,7 +99,6 @@ var _ = Describe("Podman pod create", func() { }) It("podman create pod with network portbindings", func() { - Skip(v2remotefail) name := "test" session := podmanTest.Podman([]string{"pod", "create", "--name", name, "-p", "8080:80"}) session.WaitWithDefaultTimeout()